Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy PR #38

Open
wants to merge 87 commits into
base: master
Choose a base branch
from
Open

Dummy PR #38

wants to merge 87 commits into from

Conversation

anilhelvaci
Copy link
Collaborator

Dummy PR

erights and others added 30 commits June 18, 2024 14:03
refs: Agoric#9281

## Description
AsyncFlow requires that everything passing the membrane is durable. This makes the facade objects durable to conform.

Doing so for `localChainFacade` is deferred so we can get this into master sooner, to aid @erights 's Agoric#9521 .

### Security Considerations
none
### Scaling Considerations

Exo for each chain and each account

### Documentation Considerations
none
### Testing Considerations

Existing coverage

### Upgrade Considerations
none, not yet deployed
refs: Agoric#9281

## Description

AsyncFlow requires that everything passing the membrane is durable. This makes the facade objects durable to conform.

Following Agoric#9529 

### Security Considerations
none

### Scaling Considerations
Exo for each chain and each account


### Documentation Considerations
none

### Testing Considerations
Existing coverage


### Upgrade Considerations
not yet deployed
Vat termination now makes the kernel do a console.log like:

 `kernel terminating vat v6 (failure=true)`

Vat upgrade now announces the start of the upgrade process with:

 `attempting to upgrade vat v6 from incarnation 0 to source b1-..`

in addition to announcing the success or failure of the upgrade

 `vat v6 upgraded from incarnation 0 to 1 with source b1-..`
 or
 `WARNING: vat v6 failed to upgrade from incarnation 0 (startVat)`
refs: Agoric#9449 

## Description

- [x] convert icqConnectionKit to return vows
- [x] convert Orchestration service (`service.js`) to return vows 
- [x] convert chainAccountKit to return vows

### Security Considerations


### Scaling Considerations

These changes are necessary towards supporting using `orchestration` in `asyncFlow`. 


### Documentation Considerations


### Testing Considerations


### Upgrade Considerations
refs: Agoric#9281 

## Description

AsyncFlow requires that everything passing the membrane is durable. This makes the ChainHub durable by making it an Exo.


### Security Considerations
none

### Scaling Considerations

It's a singleton, because there will only be one per vat.

### Documentation Considerations
none

### Testing Considerations
Existing coverage

### Upgrade Considerations
Not yet deployed.

Now that it's an Exo, we have to consider its state an upgradability. We expect to make a new one on each vat invocation. The only state it has is cache of AgoricNames and data supplied by the contract.
anilhelvaci and others added 29 commits June 22, 2024 01:07
fix(liquidationVisibility): fix dependency errors
Refs: #24

fix(liquidationVisibility): fix race condition when running tests concurrently

fix(liquidationVisibility): fix test-vaultLiquidation.js
author anilhelvaci <anilhelvaci96@gmail.com> 1708371947 +0300
committer anilhelvaci <anilhelvaci96@gmail.com> 1708960452 +0300

fix(liquidationVisibility): lint fix

fix(liquidationVisibility): lint fix

fix(liquidationVisibility): lint fix

fix(liquidationVisibility): fix paths

fix(liquidationVisibility): lint and type fixes

fix(liquidationVisibility): lint fixes
…e for readability (WiP)

fix(liquidationVisibility): fix unit tests after rebase updates
…onVisibilityWriters` resulted with below changes;

* Use `Promise.all` instead of `allValuesSettled`
* Remove `liq-rejected-schedule` and `liq-rejected-timestampStorageNode` as we don't need to handle those cases anymore
* Write an error message in postAuction and auctionResults recorder kits in the case of an error in distributing plans

Refs: #35
TODO: Update bootstrap tests as well

Refs: #35 #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants